Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change storage header from Storages to Storage Locations #2410

Merged
merged 2 commits into from
Sep 30, 2018
Merged

change storage header from Storages to Storage Locations #2410

merged 2 commits into from
Sep 30, 2018

Conversation

jacobherrington
Copy link
Contributor

Change the header "Storages" to "Storage Locations" in English.

screen shot 2018-09-18 at 10 17 45 am

screen shot 2018-09-18 at 10 19 52 am 1

This is more consistent with the "Add Storage Location" button and makes more sense in English. Happy to hear feedback!

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Sep 19, 2018
@ZeroX-DG
Copy link
Member

Can you edit the My storage label too?

@jacobherrington
Copy link
Contributor Author

@ZeroX-DG @samherrington made the change!

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Sep 23, 2018
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 🎉

@ZeroX-DG ZeroX-DG added next release (v0.11.10) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Sep 23, 2018
@Rokt33r Rokt33r merged commit e0e0fbf into BoostIO:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants