-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PR Template and update docs #2504
Conversation
@ZeroX-DG I like the template but I find the progress bar due to the checkboxes to be a little puzzling... |
Yeah, I also feel a bit annoying 😠 What should I do? Do you have any idea @daiyam |
<!-- | ||
Please make sure you fill in these checkboxes, | ||
your PR will be reviewed faster if we know exactly what it does. | ||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZeroX-DG can you add the following text?
Put an `x` in all the boxes that apply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daiyam Thanks for the feedback, I've updated the message. Do you have any other idea?
@daiyam It looks ugly 😢 Is there any other way? Maybe I'll just make a list of option in comment block and contributors can uncomment the applicable option |
Maybe with emoticon:
|
Oh, that's a brilliant idea! I'll update it soon |
@ZeroX-DG , |
@jangtsekiang I have added a link and created a doc for code style in this PR. |
When will it be merged? |
I'm not sure, @Rokt33r is pretty busy. |
Description
This PR added a pull request template and update docs to keep it up to date
Issue fixed
#2528
Type of changes
Checklist: