-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show the scroll bar when the tag list is overflow #2720
Conversation
browser/main/Detail/TagSelect.styl
Outdated
@@ -3,15 +3,12 @@ | |||
align-items center | |||
user-select none | |||
vertical-align middle | |||
width 100% | |||
width 96% | |||
overflow-x scroll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change overflow-x scroll
to overflow-x auto
so the scroll bar is shown only when needed π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daiyam, Even without overflow-x auto
, the scroll bar will not show by default unless the tag list is overflow, not sure why the behavior is like this....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think it looks good ! |
@richardtks can you push your code? |
@ZeroX-DG, Sorry, I missed out your reply. I have pushed the code. Please check π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π
Description
When the number of tags exceed the width of the window, scroll bar is not showing.
Issue fixed
#2688
Type of changes
Checklist:
Screenshot: