feat(completion): support sourcing zsh completion dynamically #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegerot
force-pushed
the
vegerot/source_completion
branch
3 times, most recently
from
78e7e1a to
1b28717
Compare
vegerot
force-pushed
the
vegerot/source_completion
branch
from
1b28717 to
a7de1f8
Compare
vegerot
commented
Dec 31, 2024
okdana
reviewed
Dec 31, 2024
Summary: Previously, you needed to save the completion script to a file and then source it. Now, you can dynamically source completions in zsh by running ```zsh $ source <(rg --generate complete-zsh) ``` Test plan: 1. Run `source <(rg --generate complete-zsh)` 2. Run `rg --generate=complete-zs<TAB>` Before this commit, you would get an error after step 1. After this commit, it should work as expected. Closes BurntSushi#2956
vegerot
force-pushed
the
vegerot/source_completion
branch
from
a7de1f8 to
7c2a7b0
Compare
|
I've left it in the FAQ and fixed up the wording by adding an appropriate caveat emptor. I guess since other projects have found it useful to suggest this method it's probably not too big of a deal for ripgrep to do it too. But the text now makes it clear that the "generate and source" approach is slower. 4ms might not seem like much, and indeed, I cannot perceive a 4ms lag, but if you accrue 10 of those kinds of things, it starts to pile up into something that is noticeable. |
|
@BurntSushi I'm using a self-built version now, but jooc when will the next release be so others can use it? |
|
I don't know, sorry. See: https://github.com/BurntSushi/ripgrep/blob/master/FAQ.md#when-is-the-next-release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously, you needed to save the completion script to a file and then
source it. Now, you can dynamically source completions in zsh by
running
Test plan:
source <(rg --generate complete-zsh)rg --generate=complete-zs<TAB>Before this commit, you would get an error after step 1.
After this commit, it should work as expected.
Closes #2956