-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Edit] Fix typo in CSS Overflow entry #5917
Open
joegorithm
wants to merge
5
commits into
Codecademy:main
Choose a base branch
from
joegorithm:fix-css-overflow-typo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamtawardhani
added
enhancement
New feature or request
css
CSS entries
status: ready for next review
labels
Jan 6, 2025
mamtawardhani
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to Codecademy Docs @joegorithm 😄
The entry looks good for a second round of review! 🚀
Radhika-okhade
added
status: under review
Issue or PR is currently being reviewed
status: review 1️⃣ completed
and removed
status: ready for next review
labels
Jan 7, 2025
Fixed the description. It was too long.
Radhika-okhade
approved these changes
Jan 8, 2025
Radhika-okhade
added
status: review 2️⃣ completed
and removed
status: under review
Issue or PR is currently being reviewed
labels
Jan 8, 2025
Thank you for contributing to Codecademy Docs @joegorithm 😄 The entry looks good to be merged. 🚀 |
fixed lint issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
css
CSS entries
enhancement
New feature or request
status: review 1️⃣ completed
status: review 2️⃣ completed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
:
) on line 19 of /content/css/concepts/overflow/overflow.mdIt was previously this:
And I changed it to this to match other list items:
Type of Change
Checklist
main
branch.Issues Solved
section.