Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tracks and lessons with dynamic segnments #18

Merged
merged 28 commits into from
Sep 16, 2024

Conversation

Markkos89
Copy link
Collaborator

@Markkos89 Markkos89 commented Sep 1, 2024

Changes

  • dynamic segnments fundamentals and tracks pages
    before:
    image

now:
image

  • using generateStaticParams() Next.js method to generate statically at build time lessons and tracks pages. i.e.:
    image

  • Left some TODO's and DEV_NOTES around:
    image

IMPORTANT: We need to populate the database with authors information and authors relationship with tracks and lessons so we can populate dynamically the author information in the TrackLayout component cc: @kempsterrrr

related to #15

API Updates

New Features (required)

Fixes #
Connects #

@Markkos89 Markkos89 added the enhancement New feature or request label Sep 1, 2024
@Markkos89 Markkos89 self-assigned this Sep 1, 2024
Copy link

vercel bot commented Sep 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-t3-app-router ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 11:59pm

@kempsterrrr
Copy link
Member

Can you ELI5 what is happeing in this PR please @Markkos89 ? I'm not sure what we're trying to achieve :)

@Markkos89
Copy link
Collaborator Author

Can you ELI5 what is happeing in this PR please @Markkos89 ? I'm not sure what we're trying to achieve :)

  • we are building more pages statically now.
  • we are reusing Layout.tsx and Page.tsx files instead of creating one per lesson & per track.
  • the markdown content is moved to a dedicated folder

This enhancements should make the app more SEO friendly

IMPORTANT: Now that we are reusing the layouts we have to populate the database with authors information and create the relationship of each author with the proper track and lesson. @kempsterrrr 🙏

@Markkos89
Copy link
Collaborator Author

@kempsterrrr going to merge this

@Markkos89 Markkos89 merged commit 283736e into main Sep 16, 2024
2 checks passed
@kempsterrrr
Copy link
Member

S H I P IT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants