Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can now flip angle #161 #197

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Can now flip angle #161 #197

merged 1 commit into from
Nov 29, 2024

Conversation

ssejrog
Copy link
Member

@ssejrog ssejrog commented Nov 29, 2024

Summary:

Can now flip angle with odom_theta_flip
This does cause breaking changes, as odom_x_direction_flip was renamed to odom_x_flip and odom_y_direction_flip was renamed to odom_y_flip. The getters still have direction in them

Motivation:

Mirrored field problem

References (optional):

#161

Test Plan:

Run this with and without odom_theta_flip

  chassis.odom_theta_flip();

  chassis.pid_odom_set({{0_in, 18_in, 45_deg}, fwd, 110},
                       true);
  chassis.pid_wait();

  chassis.pid_turn_set(90_deg, 110, true);
  chassis.pid_wait();

Download the template for this pull request:

Note

This is auto generated from Add Template to Pull Request

curl -o [email protected]+71e6e8.zip https://nightly.link/EZ-Robotics/EZ-Template/actions/artifacts/2255278079.zip;
pros c fetch [email protected]+71e6e8.zip;
pros c apply [email protected]+71e6e8;
rm [email protected]+71e6e8.zip;

@ssejrog ssejrog self-assigned this Nov 29, 2024
@ssejrog ssejrog merged commit cc324c3 into dev Nov 29, 2024
2 checks passed
@ssejrog ssejrog deleted the feature/mirrored-field-angle-flip branch December 18, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant