tinydisk: allow access to MAX_PARTth partition #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Space in td_lba[][] is reserved for MAX_PART+1 partitions (index 0 being whole disk), so access to [MAX_PART] is allowed (and without it you can't access hda5.
|
Will take a look when I get a moment and work out what I was thinking. The PC base partitions only allow for 4 plus the whole disk however. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Space in td_lba[][] is reserved for MAX_PART+1 partitions (index 0 being whole disk), so access to [MAX_PART] is allowed (and without it you can't access hda5).
Edit: May be that dropping MAX_PART to 4 is also the "right thing" here - I just noticed it wasn't allowing hda5 which was enumerated in the CCPT hook because MAX_PART is 5.