Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit code 2 due to ugrep: warning: cannot decompress unsupported compression format: tests/archive.tar.bz3 #448

Closed
vt-alt opened this issue Dec 25, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@vt-alt
Copy link

vt-alt commented Dec 25, 2024

I tried to disable bzip3 support [because it does not compile anymore], but after this ugrep -r -z started to produce error exit code (2) related to a warning: ugrep: warning: cannot decompress unsupported compression format: tests/archive.tar.bz3 (on test run ugrep source code).

Maybe it would be better to treat unsupported compression format as a binary file instead?

Now new compression formats (if in future) added to ugrep but not compiled in would cause unexpected error exit code, because there is such unsupported file (but supported for generating errors), this would cause some scripts to unexpectedly to fail (by a logic not based on matches found or not).

@genivia-inc
Copy link
Member

I agree. It makes sense to not exit with code 2 in this case.

@genivia-inc genivia-inc added the enhancement New feature or request label Dec 27, 2024
genivia-inc added a commit that referenced this issue Dec 30, 2024
genivia-inc added a commit that referenced this issue Dec 30, 2024
@genivia-inc
Copy link
Member

Fixed in 7.1.2.

@vt-alt
Copy link
Author

vt-alt commented Dec 30, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants