Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to golang 1.23.0 #2365

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Upgrade to golang 1.23.0 #2365

merged 2 commits into from
Aug 20, 2024

Conversation

ashmeenkaur
Copy link
Collaborator

@ashmeenkaur ashmeenkaur commented Aug 19, 2024

Description

Upgrade to golang 1.23.0

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - Ran via KOKORO (passed)
  4. Perf test -
    golang1 23

@ashmeenkaur ashmeenkaur added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Aug 19, 2024
@ashmeenkaur ashmeenkaur removed execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.08%. Comparing base (14e7813) to head (75ca673).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
- Coverage   79.10%   79.08%   -0.02%     
==========================================
  Files         105      105              
  Lines       11620    11620              
==========================================
- Hits         9192     9190       -2     
- Misses       1968     1970       +2     
  Partials      460      460              
Flag Coverage Δ
unittests 79.08% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashmeenkaur ashmeenkaur requested a review from sethiay August 19, 2024 13:31
@ashmeenkaur ashmeenkaur marked this pull request as ready for review August 19, 2024 13:31
@ashmeenkaur ashmeenkaur requested review from Tulsishah and a team as code owners August 19, 2024 13:31
@kislaykishore kislaykishore requested review from a team and gargnitingoogle and removed request for a team August 19, 2024 13:32
@ashmeenkaur ashmeenkaur added the execute-perf-test Execute performance test in PR label Aug 19, 2024
@ashmeenkaur ashmeenkaur removed the request for review from gargnitingoogle August 19, 2024 13:32
Copy link
Contributor

@sethiay sethiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also run integration tests

@ashmeenkaur ashmeenkaur added execute-integration-tests Run only integration tests and removed execute-perf-test Execute performance test in PR labels Aug 19, 2024
@ashmeenkaur ashmeenkaur requested a review from sethiay August 19, 2024 18:21
@ashmeenkaur ashmeenkaur merged commit 20480fe into master Aug 20, 2024
15 checks passed
@ashmeenkaur ashmeenkaur deleted the upgrade_go_1.23 branch August 20, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-integration-tests Run only integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants