Add support for Homebrew wrappers #19049
Merged
+102
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
requested review from
carlocab and
Bo98
and removed request for
carlocab
Bo98
approved these changes
Jan 7, 2025
Allow the ability for a system administrator to use `HOMEBREW_BREW_WRAPPER` and `HOMEBREW_FORCE_BREW_WRAPPER` variables to enforce the usage of a particular `brew` command for non-trivial (e.g. `brew --prefix` is considered trivial, it doesn't need to write to the prefix) Homebrew commands. This also introduces a `HOMEBREW_ORIGINAL_BREW_FILE` variable for some internal usage; `HOMEBREW_BREW_FILE` was being used internally for both "how should we shell out to Homebrew" and "what should we use to check permissions on Homebrew". `HOMEBREW_ORIGINAL_BREW_FILE` is now used just for the latter case. Inspired by conversation in Homebrew/homebrew-bundle#1551 which suggested this was worth fixing in wider than just `brew bundle`.
MikeMcQuaid
force-pushed
the
brew_wrapper
branch
from
5a921f9 to
e9b4979
Compare
|
Had a different approach: https://github.com/Homebrew/brew/compare/original-brew-command?expand=1 But the one here works for me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the ability for a system administrator to use
HOMEBREW_BREW_WRAPPERandHOMEBREW_FORCE_BREW_WRAPPERvariables to enforce the usage of a particularbrewcommand for non-trivial (e.g.brew --prefixis considered trivial, it doesn't need to write to the prefix) Homebrew commands.This also introduces a
HOMEBREW_ORIGINAL_BREW_FILEvariable for some internal usage;HOMEBREW_BREW_FILEwas being used internally for both "how should we shell out to Homebrew" and "what should we use to check permissions on Homebrew".HOMEBREW_ORIGINAL_BREW_FILEis now used just for the latter case.Inspired by conversation in Homebrew/homebrew-bundle#1551 which suggested this was worth fixing in wider than just
brew bundle.