Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc 9.10.1 #178590

Merged
merged 6 commits into from
Aug 4, 2024
Merged

ghc 9.10.1 #178590

merged 6 commits into from
Aug 4, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jul 26, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Draft as need to rebase after:

Will make it easier to handle haskell-stack, darcs, dhall, hlint, and stylish-haskell in no-bottle PRs.

Only formula that I am not too sure on is agda.

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing labels Jul 26, 2024
@cho-m cho-m added CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed automerge-skip `brew pr-automerge` will skip this pull request labels Aug 1, 2024
@cho-m cho-m marked this pull request as ready for review August 1, 2024 12:53
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Aug 1, 2024
@cho-m cho-m force-pushed the ghc9.10.1 branch 3 times, most recently from 556d071 to 5f28436 Compare August 1, 2024 22:40
@cho-m cho-m added CI-linux-self-hosted Build on Linux self-hosted runner CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner labels Aug 2, 2024
@cho-m cho-m added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Aug 3, 2024
@cho-m
Copy link
Member Author

cho-m commented Aug 3, 2024

Currently only haskell-stack fails to build. Can follow up on that as doesn't impact existing bottles.

The other failure is CI specific brew fetch issue for building dependents from source, which is unrelated to PR.

If Linux deps run is similar, then should be good to merge.

Copy link
Contributor

github-actions bot commented Aug 4, 2024

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 4, 2024
@BrewTestBot BrewTestBot enabled auto-merge August 4, 2024 23:50
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 4, 2024
Merged via the queue into master with commit c9aba6d Aug 4, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the ghc9.10.1 branch August 5, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner CI-linux-self-hosted-deps Test dependents on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants