Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faust: add indirect dependency #202945

Merged
merged 1 commit into from
Jan 2, 2025
Merged

faust: add indirect dependency #202945

merged 1 commit into from
Jan 2, 2025

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Jan 1, 2025

Fixes:
Full linkage --cached --test --strict faust output
Indirect dependencies with linkage:
zstd

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka mentioned this pull request Jan 1, 2025
@iMichka iMichka added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Jan 1, 2025
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Jan 2, 2025
@cho-m
Copy link
Member

cho-m commented Jan 2, 2025

csound failure is specifically caused by faust update (#202599 - was correctly caught by CI).

Part of reason we previously didn't update to 2.74+.

In current state, Csound's faust plugin is probably broken.

There doesn't seem to be any new code changes upstream (only moving files around at https://github.com/csound/plugins/tree/develop/6.x/src/faustcsound) so may just have to disable support for Faust opcodes (will require rewriting test to not use faustcompile)

@cho-m cho-m added the CI-skip-dependents Pass --skip-dependents to brew test-bot. label Jan 2, 2025
@cho-m
Copy link
Member

cho-m commented Jan 2, 2025

Will do lighter-weight change of skipping broken feature in test - #202963. Later on can disable feature if entire Faust plugin is broken.

Fixes:
Full linkage --cached --test --strict faust output
  Indirect dependencies with linkage:
    zstd
@cho-m cho-m added the ready to merge PR can be merged once CI is green label Jan 2, 2025
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 2, 2025
Merged via the queue into master with commit 8cdfa98 Jan 2, 2025
25 checks passed
@BrewTestBot BrewTestBot deleted the faust branch January 2, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-skip-dependents Pass --skip-dependents to brew test-bot. ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants