Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk-vnc: add indirect dependencies #202946

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Formula/g/gtk-vnc.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
class GtkVnc < Formula
desc "VNC viewer widget for GTK"
homepage "https://wiki.gnome.org/Projects/gtk-vnc"
homepage "https://gitlab.gnome.org/GNOME/gtk-vnc"
url "https://download.gnome.org/sources/gtk-vnc/1.3/gtk-vnc-1.3.1.tar.xz"
sha256 "512763ac4e0559d0158b6682ca5dd1a3bd633f082f5e4349d7158e6b5f80f1ce"
license "LGPL-2.1-or-later"
Expand All @@ -25,18 +25,21 @@ class GtkVnc < Formula
sha256 x86_64_linux: "9992fdf41743bef7fb279857b510441e0b95b63082ccaad5690a36776de48089"
end

depends_on "gettext" => :build
depends_on "gobject-introspection" => :build
depends_on "meson" => :build
depends_on "ninja" => :build
depends_on "pkgconf" => :build

depends_on "at-spi2-core"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no linkage for this?

depends_on "cairo"
depends_on "gdk-pixbuf"
depends_on "glib"
depends_on "gnutls"
depends_on "gtk+3"
depends_on "harfbuzz"
depends_on "libgcrypt"
depends_on "libx11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be linux dep only?

depends_on "pango"

uses_from_macos "zlib"

Expand All @@ -45,7 +48,7 @@ class GtkVnc < Formula
end

on_linux do
depends_on "libx11"
depends_on "gettext" => :build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also a macOS dependency (see on_macos block above), so we can make the :build dependency unconditional

end

# coroutine: avoid ucontext impl on macOS M1 hardware. Remove in the next release
Expand Down
Loading