Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stencil: switch to rgst-io/stencil and upgrade to v2 #203360

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

jaredallard
Copy link
Contributor

@jaredallard jaredallard commented Jan 6, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Following https://github.com/orgs/Homebrew/discussions/5587, I'm updating the stencil formula to point to
https://github.com/rgst-io/stencil.

Upstream now points to this fork as its successor: https://github.com/getoutreach/stencil#stencil.

Open question for me is how to handle bottle changes, since the last time I made a change to formulas those didn't exist (I think?)

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Jan 6, 2025
@p-linnane
Copy link
Member

Open question for me is how to handle bottle changes, since the last time I made a change to formulas those didn't exist (I think?)

You don't need to touch the bottle block. If this PR gets merged, our publishing workflow will automatically update it.

@stefanb
Copy link
Member

stefanb commented Jan 7, 2025

Would it make sense to create stencil@1 formula?

@jaredallard
Copy link
Contributor Author

Would it make sense to create stencil@1 formula?

Good question! I don't see a pressing need for it, but I don't represent everyone 😆 I'm happy to create it if y'all feel it'd be useful/safer.

@p-linnane
Copy link
Member

Would it make sense to create stencil@1 formula?

I don't think we need this given that the original repo is listed as in maintenance mode and points to this one.

Formula/s/stencil.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 7, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 7, 2025
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your contribution!

Copy link
Contributor

github-actions bot commented Jan 7, 2025

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 7, 2025
@BrewTestBot BrewTestBot enabled auto-merge January 7, 2025 21:34
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 7, 2025
Merged via the queue into Homebrew:master with commit 44fd1f8 Jan 7, 2025
15 checks passed
@jaredallard jaredallard deleted the stencil-v2 branch January 8, 2025 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants