feat: SignedGreedyStringParser #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpenilla
force-pushed
the
signed-arguments
branch
6 times, most recently
from
d817e47 to
35696c0
Compare
Still needs platform implementations of SignedStringMapper. On Fabric/NeoForge this is simple, since we have access to game types. For Paper, I have an implementation using `reflection-remapper`, so we need to decide whether we want to expose this dependency to all cloud-paper consumers.
jpenilla
force-pushed
the
signed-arguments
branch
from
35696c0 to
d3dafcc
Compare
jpenilla
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New component
org.incendo:cloud-minecraft-signed-arguments:Implements a SignedGreedyStringParser for use in Minecraft environments. We use Adventure as the abstraction for SignedMessage, so users will have to get Adventure on the classpath for this feature to work.
The parser and Brigadier mappings are registered using the new contributor service API.
Platform implementations are handled by locating the SignedStringMapper service.
New component
org.incendo:cloud-paper-signed-arguments:Implements SignedStringMapper for Paper 1.20+
Modded
Incendo/cloud-minecraft-modded#28