IGListAdapterDelegate needs Swift name of ListAdapterDelegate #1116
Conversation
Generated by 🚫 Danger |
|
|
||
| ### Breaking Changes | ||
|
|
||
| - Added Swift annotation name to `IGListAdapterDelegate` which remove `IG` prefixe. The new name is Swift clients is `ListAdapterDelegate`. [Andrea Antonioni](https://github.com/andreaantonioni)[(tbd)](tbd) |
There was a problem hiding this comment.
typos:
prefixe--> prefixThe new name is Swift clients--> The new name for Swift clients
There was a problem hiding this comment.
Also, please replace tbd with this PR number and link 😄
|
@rnystrom we don't want to merge this until we're ready for 4.0 (unless you want to start an intermediate 4.0 branch...) |
|
Nah let’s just hold for 4.0. I’m going to merge a few things and cut 3.3 in the next couple weeks. Then we can start landing 4.0 stuff. Sent with GitHawk |
|
@andreaantonioni could you rebase this PR and address the comments from @jessesquires? |
There was a problem hiding this comment.
@iperry90 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@iperry90 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@iperry90 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Changes in this pull request
Add Swift name annotation
ListAdapterDelegatetoIGListAdapterDelegate. The breaking change is written in theCHANGELOG.mdfor the4.0.0releaseIssue fixed: #1115
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.