Added example schemes for Today/iMessage extensions #112

Sherlouk · 2016-10-23T08:16:11Z

Changes in this pull request

Offering this open to a bit of a discussion based on the comments at #77.

Created two new schemes (IGListKitTodayExample, IGListKitMessageExample) in which respectively correspond to their app extension.
Updated the Podfile to ensure they have IGListKit as a dependency
Added a super simple example reusing the LabelSectionController from the main app

Done more as a 'yes it can be done' as opposed to 'look at what can be done' hence the basic functionality but I can see ways to improve if necessary!

Pull request checklist

All tests pass. Demo project builds and runs.
I have reviewed the contributing guide

Sherlouk · 2016-10-23T08:29:00Z

Just as a secondary note I'm not sure how many of these changes are because it's a new scheme, I have a different version of CocoaPods or I simply made a mistake - revise checking! (Not big with CP)

Also my justification for iOS 10 deployment target is because of the OS changes, Apple completely revamped both of them in iOS 10 so they're changed a fair bit (Can't even do iMessage extension in older versions, though strangely it's allowed?). However, if it is desired that they match the deployment target of the library then I'm happy to make these changes!

facebook-github-bot · 2016-10-24T00:11:02Z

@rnystrom has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

edit: hit the wrong button, not actually importing this yet

Sherlouk · 2016-10-24T12:21:47Z

@rnystrom I'm not sure how you guys would like to treat the extra schemes, whether you want a demo chooser similar to the main app or whether you want one example which shows that it's possible (probably with a bit more functionality than just a few cells) and leave the alternative examples to the main app?

A bit of steer would be appreciated!

cc: @jessesquires

facebook-github-bot · 2016-10-26T08:34:38Z

@Sherlouk updated the pull request - view changes - changes since last import

coveralls · 2016-10-26T08:42:21Z

Coverage remained the same at 86.082% when pulling cdc0717 on Sherlouk:multiple-schemes into 8855b51 on Instagram:master.

rnystrom · 2016-10-27T16:40:41Z

@Sherlouk Ok finally got a chance to poke around at this, and WOW. This is so cool! 🚀

Some organizational nits:

MessageExtension dir should be IGListKitMessageExample
Same renaming for the iMessage target (haven't made iMessage apps before, hopefully this is simple)
Rebase and use the icons from 920aad6
- Idk if we need new assets, if so I have them all I can upload here
Bundle display name to "IGListKit" for all of them

@jessesquires check this out. cray:

jessesquires · 2016-10-27T18:53:35Z

that's awesome 🎉

jessesquires · 2016-10-27T18:54:17Z

should we add this to the changelog?

facebook-github-bot · 2016-10-27T19:21:01Z

@Sherlouk updated the pull request - view changes - changes since last import

rnystrom · 2016-10-27T19:21:13Z

@jessesquires good call, let's do that. cc @Sherlouk

Sherlouk · 2016-10-27T19:22:15Z

@rnystrom Thanks! ❤️
I've updated the display names to IGListKit, and refactored the scheme name & directory to match the target.

The "Today Extension" icon comes from the base app, but annoyingly the message app icon is completely different (they're slightly rectangular) so you can't use the same ones as the main app! Maybe a job for your design guys?

Just seen the message about the changelog, I'll update that now!

facebook-github-bot · 2016-10-27T19:29:38Z

@Sherlouk updated the pull request - view changes - changes since last import

Sherlouk · 2016-10-27T19:30:17Z

Wasn't sure whether to just add to the bottom (as I did) or to add a new section "Example Pack Changes" which can be specifically for changes to the example pack to distinguish against modifications to the actual library.

Happy to modify upon feedback!

facebook-github-bot · 2016-10-27T19:58:59Z

@Sherlouk updated the pull request - view changes - changes since last import

Sherlouk · 2016-10-27T20:04:39Z

There was something deep down inside me which meant I just had to move that storyboard once I saw it out of place! 😅

Also RIP travis?

jessesquires · 2016-10-27T21:01:27Z

CHANGELOG.md

@@ -18,6 +18,7 @@ This release closes the [2.0.0 milestone](https://github.com/Instagram/IGListKit
 - Fixed `-[IGListAdapter reloadDataWithCompletion:]` not returning early when `collectionView` or `dataSource` is nil and `completion` is nil. [Ben Asher](https://github.com/benasher44) [(#51)](https://github.com/Instagram/IGListKit/pull/51)
 - Added `-isFirstSection` and `-isLastSection` APIs to `IGListSectionController`
 - Added support for cells created from storyboard. [Bofei Zhu](https://github.com/zhubofei) [(#92)](https://github.com/Instagram/IGListKit/pull/92)
+- Added examples for Today & iMessage extensions. [Sherlouk](https://github.com/Sherlouk) [(#112)](https://github.com/Instagram/IGListKit/pull/112)


jessesquires · 2016-10-27T21:01:57Z

ha 😄 travis should be working ok (but will probably take awhile)

Sherlouk · 2016-10-27T21:25:43Z

Are we happy with the overall complexity of these examples?

Started with very basic functionality, but not sure if I should do something a bit more exciting! Open to suggestions there, or just to leave it as is

jessesquires · 2016-10-27T21:30:48Z

@Sherlouk - I think this is good for this PR. Feel free to open a new issue to discuss! 😄

rnystrom · 2016-10-27T21:45:52Z

Simple is good! More a proof of concept that this is possible w/ fairly minimal setup.

The other thing this shows off is the fact that you can build a single section controller and share it between different targets/implementations! Pretty slick.

@jessesquires should we make the LabelSectionController class that all 3 examples use live in a shared lib? Or is having the message and today widget use a section controller from the main example app ok?

Sherlouk · 2016-10-27T22:09:27Z

While in a full application I'd probably agree with your suggestion there Ryan, I actually think in an example pack like this it's much easier to follow the chain of target membership if you can simply see the section controller can be used in multiple targets.

Just my two cents :)

jessesquires · 2016-10-27T22:13:36Z

yeah, agree with @Sherlouk 💯

coveralls · 2016-10-27T22:21:37Z

Coverage remained the same at 86.194% when pulling 8fd998a on Sherlouk:multiple-schemes into b99776e on Instagram:master.

coveralls · 2016-10-27T23:08:26Z

Coverage remained the same at 86.194% when pulling 8fd998a on Sherlouk:multiple-schemes into b99776e on Instagram:master.

coveralls · 2016-10-27T23:26:55Z

Coverage remained the same at 86.194% when pulling 8fd998a on Sherlouk:multiple-schemes into b99776e on Instagram:master.

Sherlouk · 2016-10-27T23:28:17Z

Builds are done! 🎉 🎉

facebook-github-bot · 2016-10-28T16:40:04Z

@Sherlouk updated the pull request - view changes - changes since last import

coveralls · 2016-10-28T17:25:13Z

Coverage remained the same at 86.194% when pulling 3f6524c on Sherlouk:multiple-schemes into eca0205 on Instagram:master.

facebook-github-bot · 2016-10-29T21:58:58Z

@Sherlouk updated the pull request - view changes - changes since last import

coveralls · 2016-10-29T22:06:09Z

Coverage increased (+0.3%) to 86.482% when pulling c021251 on Sherlouk:multiple-schemes into e4a4719 on Instagram:master.

Sherlouk · 2016-10-29T22:08:20Z

Not at all sure how I've increased unit tests 🤔

@rnystrom We waiting on anything specific to progress this?

rnystrom · 2016-10-29T23:04:16Z

@Sherlouk nope! Landing internally right now

Added Today/iMessage extension targets with basic examples

cc87d10

facebook-github-bot added the CLA Signed label Oct 23, 2016

facebook-github-bot added the CLA Signed label Oct 24, 2016

jessesquires modified the milestone: 2.0.0 Oct 24, 2016

Fixed merge conflict caused by pbxproj file

cdc0717

Sherlock added 2 commits October 27, 2016 20:10

Merge remote-tracking branch 'upstream/master' into multiple-schemes

86a0f7a

Renamed scheme/directory, update display names

24eef34

Updated Changelog

a5e6183

Moved random storyboard file to own folder

8fd998a

jessesquires reviewed Oct 27, 2016

View reviewed changes

Merge remote-tracking branch 'upstream/master' into multiple-schemes

3f6524c

Fixed merge conflict (conflicted in changelog)

c021251

facebook-github-bot closed this in aba6e49 Nov 1, 2016

Sherlouk deleted the multiple-schemes branch December 30, 2016 14:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added example schemes for Today/iMessage extensions #112

Added example schemes for Today/iMessage extensions #112

Sherlouk commented Oct 23, 2016 •

edited

Loading

Sherlouk commented Oct 23, 2016

facebook-github-bot commented Oct 24, 2016 •

edited by rnystrom

Loading

Sherlouk commented Oct 24, 2016

facebook-github-bot commented Oct 26, 2016

coveralls commented Oct 26, 2016 •

edited

Loading

rnystrom commented Oct 27, 2016

jessesquires commented Oct 27, 2016

jessesquires commented Oct 27, 2016

facebook-github-bot commented Oct 27, 2016

rnystrom commented Oct 27, 2016

Sherlouk commented Oct 27, 2016

facebook-github-bot commented Oct 27, 2016

Sherlouk commented Oct 27, 2016

facebook-github-bot commented Oct 27, 2016

Sherlouk commented Oct 27, 2016

jessesquires Oct 27, 2016

jessesquires commented Oct 27, 2016

Sherlouk commented Oct 27, 2016

jessesquires commented Oct 27, 2016

rnystrom commented Oct 27, 2016

Sherlouk commented Oct 27, 2016

jessesquires commented Oct 27, 2016

coveralls commented Oct 27, 2016 •

edited

Loading

coveralls commented Oct 27, 2016 •

edited

Loading

coveralls commented Oct 27, 2016 •

edited

Loading

Sherlouk commented Oct 27, 2016

facebook-github-bot commented Oct 28, 2016

coveralls commented Oct 28, 2016 •

edited

Loading

facebook-github-bot commented Oct 29, 2016

coveralls commented Oct 29, 2016 •

edited

Loading

Sherlouk commented Oct 29, 2016

rnystrom commented Oct 29, 2016

Added example schemes for Today/iMessage extensions #112

Added example schemes for Today/iMessage extensions #112

Conversation

Sherlouk commented Oct 23, 2016 • edited Loading

Changes in this pull request

Pull request checklist

Sherlouk commented Oct 23, 2016

facebook-github-bot commented Oct 24, 2016 • edited by rnystrom Loading

Sherlouk commented Oct 24, 2016

facebook-github-bot commented Oct 26, 2016

coveralls commented Oct 26, 2016 • edited Loading

rnystrom commented Oct 27, 2016

jessesquires commented Oct 27, 2016

jessesquires commented Oct 27, 2016

facebook-github-bot commented Oct 27, 2016

rnystrom commented Oct 27, 2016

Sherlouk commented Oct 27, 2016

facebook-github-bot commented Oct 27, 2016

Sherlouk commented Oct 27, 2016

facebook-github-bot commented Oct 27, 2016

Sherlouk commented Oct 27, 2016

jessesquires Oct 27, 2016

Choose a reason for hiding this comment

jessesquires commented Oct 27, 2016

Sherlouk commented Oct 27, 2016

jessesquires commented Oct 27, 2016

rnystrom commented Oct 27, 2016

Sherlouk commented Oct 27, 2016

jessesquires commented Oct 27, 2016

coveralls commented Oct 27, 2016 • edited Loading

coveralls commented Oct 27, 2016 • edited Loading

coveralls commented Oct 27, 2016 • edited Loading

Sherlouk commented Oct 27, 2016

facebook-github-bot commented Oct 28, 2016

coveralls commented Oct 28, 2016 • edited Loading

facebook-github-bot commented Oct 29, 2016

coveralls commented Oct 29, 2016 • edited Loading

Sherlouk commented Oct 29, 2016

rnystrom commented Oct 29, 2016

Sherlouk commented Oct 23, 2016 •

edited

Loading

facebook-github-bot commented Oct 24, 2016 •

edited by rnystrom

Loading

coveralls commented Oct 26, 2016 •

edited

Loading

coveralls commented Oct 27, 2016 •

edited

Loading

coveralls commented Oct 27, 2016 •

edited

Loading

coveralls commented Oct 27, 2016 •

edited

Loading

coveralls commented Oct 28, 2016 •

edited

Loading

coveralls commented Oct 29, 2016 •

edited

Loading