Fix unsigned integer overflow #1299
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Generated by 🚫 Danger |
|
ummm @tuoxie007 r u still merging this PR? thanks |
|
@tuoxie007 can you sign the CLA? thanks |
|
@tuoxie007 can you sign the CLA? thanks |
Sorry for late, done for cla. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you @tuoxie007 Jason, can you rebase and update the PR w/ the latest master? thx |
| @@ -33,6 +33,7 @@ + (void)_cleanIndexPathsWithMap:(const std::unordered_map<NSInteger, IGListMoveI | |||
| indexPaths:(NSMutableArray<NSIndexPath *> *)indexPaths | |||
| deletes:(NSMutableIndexSet *)deletes | |||
| inserts:(NSMutableIndexSet *)inserts { | |||
| if (indexPaths.count == 0) return; | |||
There was a problem hiding this comment.
Let's use {} :))
if (indexPaths.count == 0) {
return;
}
There was a problem hiding this comment.
@lorixx is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@tuoxie007 has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@lorixx has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@tuoxie007 has updated the pull request. You must reimport the pull request before landing. |
|
@TimOliver merged this pull request in 164f39c. |
Summary: ## Changes in this pull request Issue fixed: # ### Checklist - [ ] All tests pass. Demo project builds and runs. - [ ] I added tests, an experiment, or detailed why my change isn't tested. - [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1299 Reviewed By: m3rlin45 Differential Revision: D18703628 Pulled By: TimOliver fbshipit-source-id: d347ed9c59c62ccdb73bd3abd14e289b7c06f3f6
Changes in this pull request
Issue fixed: #
Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.