Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spirv-val: Initial SPV_EXT_mesh_shader builtins #5080

Merged

Conversation

spencer-lunarg
Copy link
Contributor

Adds the basic validation of storage class and type for the 4 new builtins fromSPV_EXT_mesh_shader

@s-perron
Copy link
Collaborator

The smoke test is failing because of this change. The three failing tests are:

[  FAILED  ] Glsl/CompileToSpirv14Test.FromFile/spv_ext_meshShaderBuiltins_mesh, where GetParam() = "spv.ext.meshShaderBuiltins.mesh"
[  FAILED  ] Glsl/CompileToSpirv14Test.FromFile/spv_ext_meshShaderRedeclBuiltins_mesh, where GetParam() = "spv.ext.meshShaderRedeclBuiltins.mesh"
[  FAILED  ] Glsl/CompileToSpirv14Test.FromFile/spv_460_subgroupEXT_mesh, where GetParam() = "spv.460.subgroupEXT.mesh"

@sjfricke I'll merge, but you will need to either fix glslang or fix the errors in spir-v with a separate PR. Whatever needs to be done.

@s-perron s-perron merged commit f0b900e into KhronosGroup:main Jan 23, 2023
@spencer-lunarg
Copy link
Contributor Author

@s-perron sounds good, there are some other mesh shading related issues I need to get to as well which might be related

@greg-lunarg
Copy link
Contributor

The prevailing opinion is that the Vulkan spec is in error and the glslang tests are correct. Therefore this PR is partially in error. Please see KhronosGroup/glslang#3044

@greg-lunarg
Copy link
Contributor

@s-perron I think a revert makes the most sense at this time. Thanks!

s-perron added a commit that referenced this pull request Jan 24, 2023
s-perron added a commit that referenced this pull request Jan 24, 2023
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-meshbuiltin branch May 1, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants