-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better registration support for a wide range of third-party hardware #20349
base: master
Are you sure you want to change the base?
Conversation
Examples here: https://github.com/uniartisan/RWKV-PEFT/blob/device-enhance/train.py#L499 There are a lot of things to be checked, I will try to do it later and make it more clear in documentation |
f863645
to
baf3e5c
Compare
ae3ae6b
to
ce680a2
Compare
8f0b3d6
to
2a89640
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20349 +/- ##
========================================
- Coverage 88% 87% -1%
========================================
Files 267 267
Lines 23380 23459 +79
========================================
- Hits 20481 20377 -104
- Misses 2899 3082 +183 |
1c83154
to
15595bf
Compare
4299dfe
to
decb98a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the interesting PR! I added a few comments.
hey @uniartisan are you willing to finish this one up? It would be a welcome contribution |
sorry for my late reply. I will solve them tomorrow! |
c0a62ec
to
8cde331
Compare
bdb81d4
to
01a931d
Compare
01a931d
to
5cdd9e7
Compare
will you add DirectML? |
What I've added is the code for plug-in registration, which means you can register Direct ML by yourself. Just write a few simple function 🤓 |
Thank you @uniartisan! |
What does this PR do?
Thank you to the lightning team for providing such an easy-to-use, clearly designed library.
The pr draft hopes to provide better registration support for a wide range of third-party hardware, and the pr is designed to integrate third-party hardware with minimal intrusive changes, including intel XPU, Huawei Ascend NPU, Cambrian, Moorethreads, and more.
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20349.org.readthedocs.build/en/20349/