[ModelRunner] Fix stop and bad words list contiguous for offsets #1815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our regression tests of the
ModelRunner
we noticed that in the current main branch (Jun 18, 2024) thestop_words_list
feature does not work properly for batch_size > 1. The issue seems to be that the token arrays are not contiguously layed out in memory due to the transpose that is done in this line:TensorRT-LLM/tensorrt_llm/runtime/generation.py
Line 104 in 2a115da
This makes the array offsets that are created invalid.
In
examples/run.py
this features was deactivated for a long time, but it seems that originally the contiguous was implemented here:TensorRT-LLM/examples/run.py
Line 403 in b777bd6
Thanks for taking a look at this