Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default RayTracedRenderer #103

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

orperel
Copy link
Collaborator

@orperel orperel commented Jan 12, 2023

In Wisp, objects displayed on the interactive visualizer canvas are represented by BottomLevelRenderer instances.
For neural fields, this means a BottomLevelRenderer represents a pair of neural field & tracer.

NeuralRadianceFieldPackedRenderer, for example, registers @field_renderer(BaseNeuralField, PackedRFTracer), so any neural field traceable by PackedRFTracer is supported by it.
Before this PR, adding a new subclass of BaseTracer (not a subclass of PackedRFTracer) would mean one had to also implement a corresponding BottomLevelRenderer to display that object.

With this PR, any BaseNeuralField + BaseTracer subclasses combo that did not register a @field_renderer would automatically use the default renderer:RayTracedRenderer.

Note that specialized Renderers may still be required for:

  1. Defining optimal conditions of when the object should be refreshed / redrawn
  2. Painting additional data layers
  3. Defining custom behavior for interactive mode / pre-render / post-render.

Signed-off-by: operel [email protected]

Default tracer

Various bug fixes: circular dependencies, tracer args, tracer copying

Adjust default settings when no explicit renderer exists

trigger ci

trigger ci post rebase

Signed-off-by: operel <[email protected]>
@orperel orperel merged commit 16a2ae5 into NVIDIAGameWorks:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant