run on windows, add point drawing #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draw points
|
Thank you for this super important & useful contrib!! I tested this on both Windows & Linux and everything seems to work as intended 😁 I just left one small comment which would be great if you can quickly address before we merge this! |
|
Somehow i dont see a comment now, maybe it was on the file i removed? Please feel free to push to the branch if thats faster |
|
Here's a screenshot of the comment:
(might end up pushing to the branch!) |
|
Deleted, moved to https://gist.github.com/3a1b2c3/c30ba5b3689680af04583c5bb9a0c083 in case somebody has trouble with environment. I couldn't get it to work wit CUDA 11.6 because of pytorch C bindings I think. Did that work for you? |
|
LGTM, thanks! We can look into the issue with 11.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.