Operel/new configparser #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full training runs, to alert on performance degradation Default dataset_num_workers and output elaborate mv dataset splits when incorrect output better error for incorrect nerf dataset path and make sure sdf validation runs in CI change triplanar grid marcher to voxel for aabb NeRF app README NGLOD app README NGLOD app README clarification remove unused files Set default PE to none stabilization bug fix Various MR fixes Add eval results to NeRF README Updated README, removed dynamic cfg example, and trainer fix Updated README latest changes Add new blocks figure Resize block figure organize nerf readme Signed-off-by: operel <[email protected]>
orperel
force-pushed
the
operel/new_configparser
branch
from
c578734 to
8dc1ab9
Compare
This was referenced Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lion part of the reformat finally breaks backwards compatibility to introduce the new config parser and clear separation to apps.
main.pyandmain_interactive.pyconfigs.yamlis no longer relevant, apps have their own configsexamples/funny_nerfwere deprecatedconfig_parser.pyheavily revised.app/nerf,app/nglod- each app now has it's own argument parsing, additionalrequirements.txt(if needed), README, and so forth. Args aim to be as close as possible to what we had before this change. Some args were removed, and defaults may have been re-set to different values (usually, if this is done it's due to recent commits which updated the configs, or due to a parameter deemed unused).examples/folder - both the SIGG demo and SPC browser are now more concise, as they should be :)cuda_guardfixed by Clement to avoid interference with the gui libraries own argparse, the SDFDataset having a different signatureAuthors: Clement Fuji-Tsang, Or Perel