Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datebetween formula #599

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alaycock
Copy link

@alaycock alaycock commented Jan 3, 2025

Description

A few formulas appear to be broken because the wrong argument is being used to determine the unit.
Additionally, intervalToDuration only returns a property if it has truthy value, despite what the docs indicate. In the case that the seconds value is zero, the returned object will not have a seconds property defined.

Fixes are:

  • Use the correct unit argument
  • Default the duration to zero if the result from intervalToDuration is undefined.

Notion Test Page ID

I have a working formula using dateBetween on this page:
https://adaminthehills.notion.site/Hi-I-m-Adam-164d424ea49f80c9b216c4425ca573c8

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-notion-x ✅ Ready (Inspect) Visit Preview Jan 3, 2025 6:00pm
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview Jan 3, 2025 6:00pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant