-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: manual start/stop session recording #276
Merged
Merged
+1,330
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisj
commented
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
marandaneto
reviewed
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
marandaneto
reviewed
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
marandaneto
reviewed
Dec 19, 2024
marandaneto
reviewed
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
ioannisj
commented
Dec 19, 2024
marandaneto
reviewed
Dec 19, 2024
marandaneto
reviewed
Dec 19, 2024
marandaneto
reviewed
Dec 19, 2024
11 tasks
marandaneto
reviewed
Jan 7, 2025
marandaneto
reviewed
Jan 7, 2025
marandaneto
reviewed
Jan 7, 2025
marandaneto
reviewed
Jan 7, 2025
4 tasks
ioannisj
commented
Jan 8, 2025
marandaneto
approved these changes
Jan 8, 2025
marandaneto
approved these changes
Jan 8, 2025
# Conflicts: # CHANGELOG.md # PostHog.xcodeproj/project.pbxproj # PostHogTests/PostHogAutocaptureEventTrackerSpec.swift # PostHogTests/PostHogAutocaptureIntegrationSpec.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Closes #262 and #227
Docs PR: PostHog/posthog.com#10235
Added the following:
startSessionRecording(resumeCurrent: Bool)
stopSessionRecording()
Session Management
Related discussion: https://posthog.slack.com/archives/C03PB072FMJ/p1733146678787689?thread_ts=1732810962.491699&cid=C03PB072FMJ
Based on the discussion above, I refactored how we manager and rotate replay sessions. Quite a big change but the main points of the change are:
getSessionId
changes form and is now responsible on running validation rules and rotates or clears the session if needed before returninggetSessionId
can be called withreadOnly
to skip validation and just return current session id. In both cases, a new id will be created if it doesn't exist but only when the app is foregrounded.now
is used. For replay, we capture the timestamp of the event as soon as possible, so we need to run session validation checks on that timestamp to account for delayed captures$snapshot
events add their own$session_id
property which is acquired as early as possible andcapture()
method will respect that $session_id$snapshot
events always callcapture()
with a given timestamp, acquired as early as possiblereason
on hedgeLog messages related to session id changes for debugging purposesTODO:
💚 How did you test it?
📝 Checklist