Some group theory tools for Quantum error correction #293

IsaacP1234 · 2024-06-18T04:13:19Z

Implemented groupify function to find group of Paulis generated by a generating set.

Implemented get_generating_set function to find minimal generating set of a group of Paulis.

Implemented normalize function to find all Paulis that commute with a given set of paulis.

Implemented center function to find all Paulis within a set that commute with all other elements of that set.

Added united tests for all four functions.

Krastanov

Looks like a great start! Let's do some final polish so that we have what is currently available merged, before we worry about more sophisticated functionality. Doing small merges often is much easier for me than doing large pull requests.

Converting to draft for now. Convert back to non-draft and re-request a review when ready.

@KDGoodenough , could you check whether the tests seem reasonable for the functionality you have in mind?

Krastanov · 2024-06-18T14:42:28Z

src/grouptableaux.jl

+    s, _, r = canonicalize!(copy(s), ranks=true)
+    if r == 0
+        gs = zero(Stabilizer, 1, nqubits(s))
+        if (1im * zero(Stabilizer, 1, nqubits(s))[1]) in s


use phases(s) to get just the list of phases

Krastanov · 2024-06-18T14:43:40Z

src/grouptableaux.jl

+        end
+        return gs
+    else
+        return s[1:r, :]


So if we have S"XX iII" this will fail to acknowledge the existence of these i phases, right?

which is fine if given what we said elsewhere about dealing only with real phases

Krastanov · 2024-06-18T14:45:23Z

src/grouptableaux.jl

+
+"""
+For a given non-necessarily-minimal generating set represented as a tableau `s`,
+return the minimal generating set.


add a warning that only real phases are permitted

and simplify your code accordingly

Krastanov · 2024-06-18T17:59:29Z

src/grouptableaux.jl

@@ -0,0 +1,284 @@
+#using QuantumClifford


clean up various comments, etc. A submitted pull request should be ready for merging.

Krastanov · 2024-06-18T18:01:22Z

src/grouptableaux.jl

+# `invert' arbitrary groups
+
+"""
+input: (generating) set of PauliOperator


Check other docstrings in the library, e.g. at http://qc.quantumsavory.org/stable/API/ and follow a similar style.

E.g. a very brief one-line header followed by a paragraph of narative text explaining what is happening. The input and output description can be just part of the text, no need for separate bullets if the function is simple.

Almost all the functions in the API have the one-line header and then some code examples. For simpler functions like groupify and pauligroup, should I include the paragraph portion?

yup, groupify will not be simple to someone new to the concept

Krastanov · 2024-06-18T18:10:11Z

src/grouptableaux.jl

+# s = S"XXII IIXX ZIZI IZIZ"
+# s = groupify(s)
+
+#s = S"II YY"
+#s = groupify(s)
+
+#println(normalize(s))
+
+##
+# Pgroup = pauligroup(2)
+# println(Pgroup)
+##
+
+# scenter = center(s)
+# print(scenter)
+# println(canonicalize!(s)[1:,])
+
+# function center(s::Stabilizer) # centerify? centrify?
+#     #  # returns pairs of non-commuting generators
+# end
+
+# function


Krastanov · 2024-06-18T18:10:30Z

src/grouptableaux.jl

+
+
+
+function contract(s::PauliOperator, subset)


probably needs a better name and a docstring

Krastanov · 2024-06-18T18:12:29Z

src/grouptableaux.jl

+    return Stabilizer([P for P in contract.(𝒮, (subset,)) if !isnothing(P)])  # make more efficient
+end =#
+
+function delete(s::PauliOperator, subset)


Should be the standard function Base.deleteat!, not a new function delete. If it is being implemented, it should probably go in the file where setindex and getindex are defined.

getindex and setindex are defined in densecliffords.jl, paulioperators.jl, and QuantumClifford.jl. Should I place this function in QuantumClifford.jl as it seems to be the "base" file?

probably in paulioperators

Krastanov · 2024-06-18T18:12:41Z

src/grouptableaux.jl

+# s1 = S"XIXIZIII ZZIIXIII ZIZIIXII IZIZIIXI ZIIIXIIX IIXIIZII IIIXIIZI IXIXZIIZ"
+# s1 = groupify(s1)
+
+# println("______!!!")
+# s1 = delete(s1, [6, 7, 8])
+# s1 = contract(s1, [5])
+
+
+# s2 = S"XIXIZIII ZZIIXIII ZIZIIXII IZIZIIXI ZIIIXIIX IIXIIZII IIIXIIZI IXIXZIIZ"
+# s2 = groupify(s2)
+
+# println("______!!!")
+# s2 = contract(s2, [6, 7, 8])
+# s2 = contract(s2, [5])
+
+
+# println(canonicalize!(s))
+# println("______!!!")
+
+# logical operators
+# s = contract(s, [6, 7, 8])
+# s = delete(s, [5])
+#println(canonicalize!(s))
+
+
+# s_contract = contract(s, [1,2])
+
+
+# println("-----")
+
+# s = S"XZ ZX"
+# s = groupify(s)
+
+# s = S"XZZ ZXZ ZZX"
+# s = groupify(s)
+
+# s = Stabilizer(wheel_graph(6))
+# s = groupify(s)
+
+# deleted = delete(s, [1])
+# println(canonicalize!(deleted))
+# println("_---")
+# contracted = contract(s, [1])
+# println(canonicalize!(contracted)[1:4])
+
+# println("---")
+# using QuantumClifford.ECC
+
+# println(canonicalize!(parity_checks(Perfect5())[:,[1, 2, 3, 5, 4]]))
+# println(typeof(groupify(S"XZ ZX")))
+
+
+# # md = MixedDestabilizer(s); groupify(copy(vcat(stabilizerview(md), logicalxview(md), logicalzview(md)))) x


Krastanov · 2024-06-18T18:14:12Z

CHANGELOG.md

+Implemented get_generating_set function to find minimal generating set of a group of Paulis
+Implemented normalize function to find all Paulis that commute with a given set of paulis
+Implemented center function to find all Paulis within a set that commute with all other elements of that set
+Added united tests for all four functions


You can leave CHANGELOG unchanged to avoid merge conflicts until we are done with the reviews. You probably want to rebase this on master:

git checkout master git pull # potentially with specifying the upstream remote git checkout some_group_functions git rebase master

IsaacP1234 · 2024-07-23T01:55:23Z

Adding a see also from trace! to delete_columns causes the docs to fail to build, I think because the project_trace_reset.jl docs get created before the group_tableaux.jl ones.

Additionally, the build fails, but it seems to be an error with the second part, QuantumSavory, and not QuantumClifford. Let me know if this is not the case and I will debug it.

IsaacP1234 · 2024-07-28T21:22:25Z

CHANGELOG:
Implemented groupify function to generate stabilizer group from generating set.
Implemented minimal_generating_set function to find the minimal generating set of a Stabilizer.
Implemented pauligroup function to generate the full Pauli group of a certain length.
Implemented normalizer function to generate all Paulis that commute with a set of Paulis
Implemented centralizer function to find a subset of a set of Paulis such that each element in the subset commutes with each element in the set.
Implemented contractor function to find a subset of Paulis in a stabilizer that have an identity operator on a certain qubit.
Implemented delete_columns function to remove the operators corresponding to a certain qubit from all Paulis in a Stabilizer.

IsaacP1234 · 2024-07-30T00:32:01Z

@Krastanov re-pinging for review as it is now fully complete but a review request is currently active.

Krastanov · 2024-07-30T04:00:13Z

src/grouptableaux.jl

+            end
+        end
+        if commutes == 0


This does not seem to match the description. I would have expected only +X to be returned.

Krastanov

I made a few documentation changes. Generally, the documentation should say what something is and why it exists. It should say "how" only if there is something particularly non-trivial and only if the previous two questions are already fully addressed. Frequently that "how" might be just in the code comments. If the "how" is mostly obvious from the code, it should probably not even be a comment. The reasoning behind this is two-fold: (1) the user probably does not care exactly how something is implemented, rather they care what it is; (2) the implementation might change without anyone remembering the update the documentation.

I do have one question for clarification on the contract function. Otherwise the rest looks great.

…QuantumClifford.jl into some_group_functions

IsaacP1234 · 2024-08-02T02:33:22Z

I have removed the groupify functionality from contractor. PR should be all good.

Krastanov · 2024-08-03T19:59:33Z

Thanks, @IsaacP1234 , this was great!

@KDGoodenough , let's see what you are planning to use this for!

Co-authored-by: Kenneth Goodenough <[email protected]> Co-authored-by: Stefan Krastanov <[email protected]> Co-authored-by: Stefan Krastanov <[email protected]>

KDGoodenough and others added 24 commits March 27, 2024 21:12

first commit

3ec3098

added GT dependecies to project.toml

dee1c59

started GT test file

a708c00

started groupify tests

8627fee

tests for groupify/generating set, pauli ops don't work

3bf54ae

removing unnecessary dependencies

4f377b7

removed print statements

929607d

completed get_gen_set tests

1161ff2

added phase arg to pualigroup and tests for normalize

da32a75

added tests for center, fixed center

09ea8b5

formatted tests

e2af6b7

added changes to changelog

c1510a0

removed SafeTestSets dependency, formatted changelog

f22cf6e

fixed center function and pauligroup phases

5ded49b

added tests for logical_op_canonicalize

59cf3be

updated LOC tests

2076a52

updated LOC tests and CHANGELOG

b7d0eab

updated GGS+tests to work with I operators

7694800

added method descriptions

bd5e63a

removed print statements + fixed center tests

d4265dd

fixed changelog grammar

b9071e1

formatted+commented unfinished functions

43f4736

fixed changelog

afa2d17

completed changelog

c1282d8

IsaacP1234 marked this pull request as ready for review June 18, 2024 04:13

Krastanov requested changes Jun 18, 2024

View reviewed changes

Krastanov marked this pull request as draft June 18, 2024 18:24

Krastanov mentioned this pull request Jun 22, 2024

Stabilizer group function completion and testing #278

Closed

IsaacP1234 added 2 commits June 22, 2024 16:10

removed unnecessary comments

79f8f75

moved pauli delete to p_o.jl

0fc1725

IsaacP1234 added 3 commits July 20, 2024 21:30

added see also, fixed doctests+polished documentation

8cc20f8

bugfixed tests and exporting

2786c66

removed refernce to delete_columns from traceout!

14714c2

IsaacP1234 requested a review from Krastanov July 23, 2024 01:55

IsaacP1234 added 4 commits July 27, 2024 19:12

fixed reference error

3b23fa9

reset jet to 25

eb5dbfe

added changelog comments

ee3a0fa

removed changelog

121cd36

IsaacP1234 marked this pull request as draft July 30, 2024 00:30

IsaacP1234 marked this pull request as ready for review July 30, 2024 00:31

Krastanov reviewed Jul 30, 2024

View reviewed changes

This comment was marked as duplicate.

Sign in to view

minor doc cleanup

a2c8a17

Krastanov self-requested a review July 30, 2024 04:04

Krastanov requested changes Jul 30, 2024

View reviewed changes

IsaacP1234 added 2 commits July 31, 2024 22:19

removed groupify from contractor and tests

ca05512

Merge branch 'some_group_functions' of https://github.com/IsaacP1234/…

cbd2208

…QuantumClifford.jl into some_group_functions

IsaacP1234 requested a review from Krastanov August 2, 2024 02:32

Krastanov and others added 2 commits August 3, 2024 15:04

Merge branch 'master' into some_group_functions

1697097

cleanup and changelog amd version bumb

39af6f0

Krastanov approved these changes Aug 3, 2024

View reviewed changes

Krastanov merged commit b02add9 into QuantumSavory:master Aug 3, 2024
12 of 13 checks passed

Krastanov mentioned this pull request Aug 22, 2024

Entanglement-assisted stabilizer formalism #344

Open

Fe-r-oz mentioned this pull request Sep 4, 2024

Additional group theory functions for error correction #351

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some group theory tools for Quantum error correction #293

Some group theory tools for Quantum error correction #293

IsaacP1234 commented Jun 18, 2024

Krastanov left a comment

Krastanov Jun 18, 2024

Krastanov Jun 18, 2024

Krastanov Jun 18, 2024

Krastanov Jun 18, 2024

Krastanov Jun 18, 2024

Krastanov Jun 18, 2024

Krastanov Jun 18, 2024

IsaacP1234 Jun 24, 2024

Krastanov Jun 24, 2024

Krastanov Jun 18, 2024

Krastanov Jun 18, 2024

Krastanov Jun 18, 2024

IsaacP1234 Jun 24, 2024

Krastanov Jun 24, 2024

Krastanov Jun 18, 2024

Krastanov Jun 18, 2024

IsaacP1234 commented Jul 23, 2024

IsaacP1234 commented Jul 28, 2024

IsaacP1234 commented Jul 30, 2024

Krastanov Jul 30, 2024

This comment was marked as duplicate.

Krastanov left a comment

IsaacP1234 commented Aug 2, 2024

Krastanov commented Aug 3, 2024

Some group theory tools for Quantum error correction #293

Some group theory tools for Quantum error correction #293

Conversation

IsaacP1234 commented Jun 18, 2024

Krastanov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IsaacP1234 commented Jul 23, 2024

IsaacP1234 commented Jul 28, 2024

IsaacP1234 commented Jul 30, 2024

Choose a reason for hiding this comment

This comment was marked as duplicate.

Krastanov left a comment

Choose a reason for hiding this comment

IsaacP1234 commented Aug 2, 2024

Krastanov commented Aug 3, 2024