-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to disable registrations #1824
Conversation
Rubocop smh:
@nilsding I'm out of clues why the redirect doesn't seem to apply to the create action POST request. Maybe you have an idea. |
One thing I noticed: the links in the sign in page still refer to "Sign up" as well |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1824 +/- ##
==========================================
+ Coverage 95.89% 95.91% +0.01%
==========================================
Files 179 180 +1
Lines 2803 2816 +13
==========================================
+ Hits 2688 2701 +13
Misses 115 115 ☔ View full report in Codecov by Sentry. |
…ments in how to access common configs when needed ... way better than using `.dig` by hand everywhere i'd say
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
A little present to the people that decide to host Retrospring themselves.
This is handled via a new configuration option in
justask.yml
:Removes all mentions of signing up from the interface (I hope) and redirects away from the sign up/user creation routes if they are tried to be accessed.
Important: This doesn't come with an invite system, so to create users you either temporarily enable registrations again, or create them manually over RailsAdmin.