Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced frontpage layout config option #1828

Merged
merged 5 commits into from
Aug 11, 2024
Merged

Conversation

pixeldesu
Copy link
Member

@pixeldesu pixeldesu commented Aug 11, 2024

The current frontpage is mostly for "marketing" purposes, displaying all the different features Retrospring has. This isn't really required for self-hosted instances. So this Pull Request adds a by default enabled simple layout.

The configuration option added for this is the following:

features:
  # Advanced (marketing) frontpage layout
  advanced_frontpage:
    enabled: false
Mobile layout Desktop layout
image image

@pixeldesu pixeldesu requested a review from nilsding as a code owner August 11, 2024 02:57
@github-actions github-actions bot added the feature Pull Requests that add a feature label Aug 11, 2024
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (66a1998) to head (784e9e0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1828   +/-   ##
=======================================
  Coverage   95.91%   95.92%           
=======================================
  Files         180      180           
  Lines        2816     2819    +3     
=======================================
+ Hits         2701     2704    +3     
  Misses        115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixeldesu pixeldesu merged commit 63ca38c into main Aug 11, 2024
13 checks passed
@pixeldesu pixeldesu deleted the feature/advanced-frontpage branch August 11, 2024 18:33
Copy link

sentry-io bot commented Aug 13, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ActionView::MissingTemplate: Missing template about/index_advanced with {:locale=>[:en], :formats=>[:json, :xml, :js], :varian... AboutController#index View Issue

Did you find this useful? React with a 👍 or 👎

@nilsding
Copy link
Member

ah, sentry errors are because of some bot activities as indicated by the headers:

Accept: application/json, application/xml, text/json, text/x-json, text/javascript, text/xml
User-Agent: RestSharp/1.0.0.0

of course there's no json template for that, silly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull Requests that add a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants