Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Enhanced the Display of Text, Image, Audio & Video Attachments #817

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dhairyashiil
Copy link
Contributor

Brief Title

Feat: Enhanced the Display of Text, Image, Audio & Video Attachments

Acceptance Criteria fulfillment

  • For Text, Image, Audio, and Video attachments, adjust the background to lighten or darken based on the light and dark themes.
  • For the Light theme, make the background darker.
  • For the Dark theme, make the background lighter.
  • Make sure the hover effect is still visible on these attachments

Fixes #816

Video/Screenshots:

Stormy Seas Dark Theme:

dark.theme.background.for.attachments.mp4

Default Light Theme:

light.theme.background.for.attachments.mp4

Rose Amber Variant Light Theme:

rose.amber.light.theme.background.for.attachments.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-817 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Enhance Background of Text, Image, Audio & Video Attachments
1 participant