Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Language Options Sorting by Using 'Name' Property. #33906

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Nov 7, 2024

Before:
Screencast from 2024-11-07 16-01-07.webm

After:
Screencast from 2024-11-07 16-02-10.webm

The language options list was previously sorted by the 'key' property. However, this approach caused incorrect sorting since some keys didn’t match the starting letters of their respective language names. I’ve updated the sorting logic to use the 'name' property instead, which has resolved the issue and now sorts the list correctly.

close #33934

CORE-810

@thepiyush-303 thepiyush-303 requested a review from a team as a code owner November 7, 2024 11:45
Copy link
Contributor

dionisio-bot bot commented Nov 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.2.0, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: bca670c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@reetp
Copy link

reetp commented Nov 8, 2024

Please don't @ people randomly in the hope of getting attention.

So nope. I can't review. I have no power over that.

Where is the bug this is meant to fix?

Have you checked this is something prlduct want a PR for? They be working on it internally....

@thepiyush-303
Copy link
Contributor Author

I apologize for my previous actions, and I appreciate your guidance. I’ll be more mindful about tagging people in the future. This PR addresses about language options list which is not being sorted correctly. It ensures the list is displayed in a properly sorted order.

@reetp
Copy link

reetp commented Nov 8, 2024

Github is for bugs and issues, not general support.

Please visit https://open.rocket.chat to ask for help.

@tassoevan tassoevan added this to the 7.1.0 milestone Nov 11, 2024
tassoevan
tassoevan previously approved these changes Nov 11, 2024
@thepiyush-303
Copy link
Contributor Author

@tassoevan can you pls. run the pending workflows which requires one approval

@reetp
Copy link

reetp commented Nov 18, 2024

@tassoevan can you pls. run the pending workflows which requires one approval

Please don't @ people randomly in the hope of getting attention.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Note there is a huge operation here that goes on out of sight.

Your PR will have to go via various reviews and teams.

You need to be a lot more patient - this can take months

@scuciatto scuciatto modified the milestones: 7.1.0, 7.2.0 Nov 18, 2024
@tassoevan tassoevan force-pushed the test branch 2 times, most recently from 16f6d5c to a6c6b86 Compare November 25, 2024 08:31
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Nov 25, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 25, 2024
@kodiakhq kodiakhq bot merged commit 7855bc3 into RocketChat:develop Nov 26, 2024
44 of 45 checks passed
@thepiyush-303 thepiyush-303 deleted the test branch November 26, 2024 06:52
ggazzo pushed a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

language options list is not sorted correctly
5 participants