-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Language Options Sorting by Using 'Name' Property. #33906
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: bca670c The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Please don't @ people randomly in the hope of getting attention. So nope. I can't review. I have no power over that. Where is the bug this is meant to fix? Have you checked this is something prlduct want a PR for? They be working on it internally.... |
I apologize for my previous actions, and I appreciate your guidance. I’ll be more mindful about tagging people in the future. This PR addresses about language options list which is not being sorted correctly. It ensures the list is displayed in a properly sorted order. |
Github is for bugs and issues, not general support. Please visit https://open.rocket.chat to ask for help. |
@tassoevan can you pls. run the pending workflows which requires one approval |
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Note there is a huge operation here that goes on out of sight. Your PR will have to go via various reviews and teams. You need to be a lot more patient - this can take months |
apps/meteor/client/views/account/preferences/PreferencesLocalizationSection.tsx
Outdated
Show resolved
Hide resolved
16f6d5c
to
a6c6b86
Compare
Co-authored-by: Tasso Evangelista <[email protected]>
Before:
Screencast from 2024-11-07 16-01-07.webm
After:
Screencast from 2024-11-07 16-02-10.webm
The language options list was previously sorted by the 'key' property. However, this approach caused incorrect sorting since some keys didn’t match the starting letters of their respective language names. I’ve updated the sorting logic to use the 'name' property instead, which has resolved the issue and now sorts the list correctly.
close #33934
CORE-810