Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move notify-user /notification and /subscriptions-changed stream events to hook #33981

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Nov 18, 2024

Proposed changes (including videos or screenshots)

Move user notifications /notification and subscriptions-changed stream events to a react hook

Issue(s)

CORE-818

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 0a17746

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 18, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33981/
on branch gh-pages at 2024-11-19 19:36 UTC

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73%. Comparing base (6ba7372) to head (0a17746).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33981      +/-   ##
===========================================
+ Coverage    75.18%   75.73%   +0.54%     
===========================================
  Files          495      507      +12     
  Lines        21600    21799     +199     
  Branches      5362     5343      -19     
===========================================
+ Hits         16241    16509     +268     
+ Misses        4717     4648      -69     
  Partials       642      642              
Flag Coverage Δ
unit 75.73% <ø> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@tiagoevanp tiagoevanp changed the title chore: Move notify-user /notification and subscriptions-changed stream events to hook chore: Move notify-user /notification and /subscriptions-changed stream events to hook Nov 18, 2024
@tiagoevanp tiagoevanp marked this pull request as ready for review November 18, 2024 18:35
@tiagoevanp tiagoevanp requested a review from a team as a code owner November 18, 2024 18:35
@dougfabris dougfabris added this to the 7.1.0 milestone Nov 18, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Nov 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 19, 2024
@ggazzo ggazzo merged commit c7bca10 into develop Nov 19, 2024
9 of 10 checks passed
@ggazzo ggazzo deleted the chore/notify-user branch November 19, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants