-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move notify-user
/notification
and /subscriptions-changed
stream events to hook
#33981
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33981 +/- ##
===========================================
+ Coverage 75.18% 75.73% +0.54%
===========================================
Files 495 507 +12
Lines 21600 21799 +199
Branches 5362 5343 -19
===========================================
+ Hits 16241 16509 +268
+ Misses 4717 4648 -69
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more.
|
notify-user
/notification
and subscriptions-changed
stream events to hooknotify-user
/notification
and /subscriptions-changed
stream events to hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes (including videos or screenshots)
Move user notifications
/notification
andsubscriptions-changed
stream events to a react hookIssue(s)
CORE-818
Steps to test or reproduce
Further comments