Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add sidepanel tests #34028

Merged
merged 5 commits into from
Dec 11, 2024
Merged

test: add sidepanel tests #34028

merged 5 commits into from
Dec 11, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Nov 21, 2024

Proposed changes (including videos or screenshots)

  • tests to cover Secondary navigation for teams feature preview
  • tests to cover SIDE-213
  • tests to cover SIDE-204

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Nov 21, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link
Contributor

github-actions bot commented Nov 21, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34028/
on branch gh-pages at 2024-12-11 17:18 UTC

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (6799f09) to head (2641f81).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34028   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          511      511           
  Lines        22132    22132           
  Branches      5394     5394           
========================================
  Hits         16775    16775           
  Misses        4709     4709           
  Partials       648      648           
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 2641f81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juliajforesti juliajforesti force-pushed the test/sidepanel branch 4 times, most recently from 372b184 to 9a4ab33 Compare November 28, 2024 19:23
@juliajforesti juliajforesti marked this pull request as ready for review December 6, 2024 21:10
@juliajforesti juliajforesti requested a review from a team as a code owner December 6, 2024 21:10
@juliajforesti juliajforesti added the stat: QA assured Means it has been tested and approved by a company insider label Dec 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 11, 2024
@kodiakhq kodiakhq bot merged commit e39db8d into develop Dec 11, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the test/sidepanel branch December 11, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants