fix: Allow any user in e2ee room to create and propagate room keys

.changeset/chilly-pants-hunt.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+Removes a validation that allowed only the room creator to propagate E2EE room keys. This was causing issues when the rooms were created via apps or some other integration, as the creator may not be online or able to create E2EE keys

apps/meteor/app/e2e/client/rocketchat.e2e.room.ts

@@ -325,9 +325,8 @@
 		}
 
 		try {
 			const room = Rooms.findOne({ _id: this.roomId })!;
-			// Only room creator can set keys for room
-			if (!room.e2eKeyId && this.userShouldCreateKeys(room)) {
+			if (!room.e2eKeyId) {
 				this.setState(E2ERoomState.CREATING_KEYS);
 				await this.createGroupKey();
 				this.setState(E2ERoomState.READY);
@@ -343,15 +342,6 @@
 		}
 	}
 
-	userShouldCreateKeys(room: any) {
-		// On DMs, we'll allow any user to set the keys
-		if (room.t === 'd') {
-			return true;
-		}
-
-		return room.u._id === this.userId;
-	}
-
 	isSupportedRoomType(type: any) {
 		return roomCoordinator.getRoomDirectives(type).allowRoomSettingChange({}, RoomSettingsEnum.E2E);
 	}
@@ -392,7 +382,7 @@
 
 		// Import session key for use.
 		try {
 			const key = await importAESKey(JSON.parse(this.sessionKeyExportedString!));
 			// Key has been obtained. E2E is now in session.
 			this.groupSessionKey = key;
 		} catch (error) {
@@ -420,7 +410,7 @@
 			await sdk.rest.post('/v1/e2e.updateGroupKey', {
 				rid: this.roomId,
 				uid: this.userId,
 				key: await this.encryptGroupKeyForParticipant(e2e.publicKey!),
 			} as any);
 			await this.encryptKeyForOtherParticipants();
 		} catch (error) {
@@ -475,7 +465,7 @@
 
 			const usersSuggestedGroupKeys = { [this.roomId]: [] as any[] };
 			for await (const user of users) {
 				const encryptedGroupKey = await this.encryptGroupKeyForParticipant(user.e2e!.public_key!);
 				const oldKeys = await this.encryptOldKeysForParticipant(user.e2e?.public_key, decryptedOldGroupKeys);
 
 				usersSuggestedGroupKeys[this.roomId].push({ _id: user._id, key: encryptedGroupKey, ...(oldKeys && { oldKeys }) });