-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Export selected room messages as JSON file #34076
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 68a5910 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34076 +/- ##
========================================
Coverage 75.81% 75.81%
========================================
Files 512 512
Lines 22208 22208
Branches 5404 5404
========================================
Hits 16837 16837
Misses 4720 4720
Partials 651 651
Flags with carried forward coverage won't be shown. Click here to find out more. |
5a4d892
to
75b93fe
Compare
d4f60be
to
da3d0fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add tests?
apps/meteor/client/views/room/composer/ComposerSelectMessages.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/providers/SelectedMessagesProvider.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/providers/SelectedMessagesProvider.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/providers/SelectedMessagesProvider.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: gabriellsh <[email protected]>
bcd1901
to
4e000f1
Compare
8e3522d
8e3522d
to
6369528
Compare
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
Proposed changes (including videos or screenshots)
Introduces a new option when exporting messages, allowing users to select and download a JSON file directly from the client
Issue(s)
Steps to test or reproduce
Further comments
CORE-807
CORE-808