Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export selected room messages as JSON file #34076

Merged
merged 18 commits into from
Dec 19, 2024
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Nov 28, 2024

Proposed changes (including videos or screenshots)

Kapture 2024-12-05 at 16 54 10

Introduces a new option when exporting messages, allowing users to select and download a JSON file directly from the client

Issue(s)

Steps to test or reproduce

Further comments

CORE-807
CORE-808

Copy link
Contributor

dionisio-bot bot commented Nov 28, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 28, 2024

🦋 Changeset detected

Latest commit: 68a5910

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/ui-composer Minor
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 28, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34076/
on branch gh-pages at 2024-12-19 14:03 UTC

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.81%. Comparing base (082d3ce) to head (68a5910).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34076   +/-   ##
========================================
  Coverage    75.81%   75.81%           
========================================
  Files          512      512           
  Lines        22208    22208           
  Branches      5404     5404           
========================================
  Hits         16837    16837           
  Misses        4720     4720           
  Partials       651      651           
Flag Coverage Δ
unit 75.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the feat/export-e2ee branch 2 times, most recently from 5a4d892 to 75b93fe Compare December 3, 2024 19:27
@dougfabris dougfabris changed the title feat: [PoC] Export E2EE messages feat: [PoC] Export room messages as file Dec 3, 2024
@dougfabris dougfabris added this to the 7.2.0 milestone Dec 5, 2024
@dougfabris dougfabris changed the title feat: [PoC] Export room messages as file feat: Export room messages as JSON file Dec 5, 2024
@dougfabris dougfabris changed the title feat: Export room messages as JSON file feat: Export selected room messages as JSON file Dec 5, 2024
@dougfabris dougfabris marked this pull request as ready for review December 5, 2024 21:51
@dougfabris dougfabris requested a review from a team as a code owner December 5, 2024 21:51
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add tests?

Co-authored-by: gabriellsh <[email protected]>
gabriellsh
gabriellsh previously approved these changes Dec 16, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Dec 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 18, 2024
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
@kodiakhq kodiakhq bot merged commit 2d41274 into develop Dec 19, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/export-e2ee branch December 19, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants