fix: twitter oembed image not showing #34079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 3acb2c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I have not yet added tests, since it would include adding a tweet link for testing. The tests will fail if the tweet is deleted. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34079 +/- ##
========================================
Coverage 75.83% 75.83%
========================================
Files 511 511
Lines 22172 22172
Branches 5397 5397
========================================
Hits 16814 16814
Misses 4710 4710
Partials 648 648
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
scuciatto
requested changes
Nov 28, 2024
MarcosSpessatto
previously approved these changes
Nov 29, 2024
scuciatto
previously approved these changes
Nov 29, 2024
abhinavkrin
dismissed stale reviews from scuciatto and MarcosSpessatto
via
c057863
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
Signed-off-by: Abhinav Kumar <[email protected]>
abhinavkrin
force-pushed
the
fix/twitter-link-oembed-image
branch
from
c057863 to
4808dea
Compare
MarcosSpessatto
requested changes
Dec 13, 2024
KevLehman
approved these changes
Dec 13, 2024
MarcosSpessatto
approved these changes
Dec 13, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This pr fixes the issue where the image is not showing link for twitter article links. This pr removes the provider for twitter oembed and hence now relies on the meta tags (which is the default behavior when a provider is not provided).
Issue(s)
Steps to test or reproduce
Further comments
SUP-685