fix: VoIP not invalidating cache on permission change #34102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 28f5001 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34102 +/- ##
========================================
Coverage 75.75% 75.75%
========================================
Files 510 510
Lines 22078 22078
Branches 5387 5387
========================================
Hits 16726 16726
Misses 4706 4706
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
aleksandernsilva
changed the title
MartinSchoeler
approved these changes
Dec 5, 2024
aleksandernsilva
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Arihant25
pushed a commit
to Arihant25/Rocket.Chat
that referenced
this pull request
Dec 5, 2024
ggazzo
pushed a commit
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR fixes
useVoipClienthook accessing theVoIP_TeamCollab_Enabledsetting directly instead of using the parameterenabledwhich covers permissions as well as the settings.Issue(s)
Steps to test or reproduce
Further comments
CONN-432