-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Introduced section-based accordion groups to the App Settings interface #34121
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 460049d The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34121 +/- ##
========================================
Coverage 75.75% 75.75%
========================================
Files 510 510
Lines 22078 22078
Branches 5387 5387
========================================
Hits 16726 16726
Misses 4706 4706
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSettings/AppSettings.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSettings/AppSettings.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppSettings/AppSettings.tsx
Outdated
Show resolved
Hide resolved
…ttings/AppSettings.tsx Co-authored-by: Tasso Evangelista <[email protected]>
Proposed changes (including videos or screenshots)
useAppTranslation
hook for section titles.useAppTranslation
hook to handle app-specific translations, improving code reuse and maintainability.useAppTranslation
function and replaced it with the newuseAppTranslation
hook.After changes:
Issue(s)
Steps to test or reproduce
Further comments
i18n
shown on the Accordion title by defining a key under the Appsi18n.json
; for example if I havesection: model
(in App settings) defining the following keyWill render the Accordion with the title as "Model Section" if no key is defined, it will show up as
model