Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduced section-based accordion groups to the App Settings interface #34121

Merged
merged 7 commits into from
Dec 5, 2024

Conversation

Dnouv
Copy link
Member

@Dnouv Dnouv commented Dec 5, 2024

Proposed changes (including videos or screenshots)

  • Added accordion groups to organize settings into sections, using the useAppTranslation hook for section titles.
  • Created a new useAppTranslation hook to handle app-specific translations, improving code reuse and maintainability.
  • Removed the local useAppTranslation function and replaced it with the new useAppTranslation hook.

After changes:

Issue(s)

Steps to test or reproduce

Further comments

  • Please note that App Developers can customize the i18n shown on the Accordion title by defining a key under the Apps i18n.json; for example if I have section: model (in App settings) defining the following key
{
...
"model": "Model Section"
...
}

Will render the Accordion with the title as "Model Section" if no key is defined, it will show up as model

Copy link
Contributor

dionisio-bot bot commented Dec 5, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@Dnouv Dnouv added this to the 7.2.0 milestone Dec 5, 2024
Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 460049d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.75%. Comparing base (924a06b) to head (460049d).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34121   +/-   ##
========================================
  Coverage    75.75%   75.75%           
========================================
  Files          510      510           
  Lines        22078    22078           
  Branches      5387     5387           
========================================
  Hits         16726    16726           
  Misses        4706     4706           
  Partials       646      646           
Flag Coverage Δ
unit 75.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Dec 5, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34121/
on branch gh-pages at 2024-12-05 07:07 UTC

@Dnouv Dnouv marked this pull request as ready for review December 5, 2024 08:40
@Dnouv Dnouv requested a review from a team as a code owner December 5, 2024 08:40
@Dnouv Dnouv requested a review from tassoevan December 5, 2024 13:40
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Dec 5, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 5, 2024
@kodiakhq kodiakhq bot merged commit 7eabf54 into develop Dec 5, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the new/app_setting_sections branch December 5, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants