Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use all initials to create avatar when setting is UI_Use_Name_Avatar is true #34124

Merged
merged 15 commits into from
Dec 17, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Dec 5, 2024

Proposed changes (including videos or screenshots)

1 name:
image

2 names:
image

3 names:
image

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-678

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 5, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 5ebde0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KevLehman KevLehman changed the title fix: Use all initials to create avatar when setting is UI_Use_Full_Name is true fix: Use all initials to create avatar when setting is UI_Use_Name_Avatar is true Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34124/
on branch gh-pages at 2024-12-17 11:50 UTC

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.83%. Comparing base (e1bb39d) to head (5ebde0a).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34124      +/-   ##
===========================================
+ Coverage    75.81%   75.83%   +0.02%     
===========================================
  Files          511      511              
  Lines        22152    22172      +20     
  Branches      5394     5397       +3     
===========================================
+ Hits         16794    16814      +20     
  Misses        4710     4710              
  Partials       648      648              
Flag Coverage Δ
unit 75.83% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review December 5, 2024 15:58
@KevLehman KevLehman requested a review from a team as a code owner December 5, 2024 15:58
MarcosSpessatto
MarcosSpessatto previously approved these changes Dec 9, 2024
@MarcosSpessatto MarcosSpessatto added this to the 7.2.0 milestone Dec 9, 2024
Gustrb
Gustrb previously approved these changes Dec 9, 2024
gabriellsh
gabriellsh previously approved these changes Dec 12, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Dec 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 16, 2024
@kodiakhq kodiakhq bot merged commit f750e21 into develop Dec 17, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/use-all-initials branch December 17, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants