-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: First response time livechat metrics are associated with the last agent who served the room #34156
Conversation
… who responded to the room
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 5fae225 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34156 +/- ##
========================================
Coverage 75.79% 75.79%
========================================
Files 511 511
Lines 22132 22132
Branches 5394 5394
========================================
Hits 16775 16775
Misses 4709 4709
Partials 648 648
Flags with carried forward coverage won't be shown. Click here to find out more. |
…who responded to the room
…om/RocketChat/Rocket.Chat into fix/first-response-metrics-forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can u add unit tests cases for your fix?
if possible, similar tests to the API tests ones 👀
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Make sure to grant the
transfer-livechat-guest
permission to agents or to a manager.Create a new agent and respond a livechat room with it, then transfer the room to another one. The "first response time" aggregation metrics are available under Omnichannel > Analytics > Productivity (or by using the
livechat/analytics/agent-overview
endpoint), and we need to make sure that both metrics related to the room that has been transferred are associated to the first agent who responded to the room (and not to the last one who served it).Further comments
CORE-669