Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: User default avatar preview not respecting Use Full Name Initials settings #34187

Merged
merged 10 commits into from
Dec 20, 2024

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Dec 16, 2024

Proposed changes (including videos or screenshots)

Issue(s)

CORE-900

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Dec 16, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 66043c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 16, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34187/
on branch gh-pages at 2024-12-20 17:55 UTC

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.27%. Comparing base (2d41274) to head (44de406).
Report is 14 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34187      +/-   ##
===========================================
- Coverage    75.81%   75.27%   -0.54%     
===========================================
  Files          512      516       +4     
  Lines        22208    22540     +332     
  Branches      5404     5485      +81     
===========================================
+ Hits         16837    16968     +131     
- Misses        4720     4911     +191     
- Partials       651      661      +10     
Flag Coverage Δ
unit 75.27% <100.00%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh marked this pull request as ready for review December 19, 2024 16:40
@gabriellsh gabriellsh requested review from a team as code owners December 19, 2024 16:40
@gabriellsh gabriellsh added this to the 7.2.0 milestone Dec 19, 2024
sampaiodiego
sampaiodiego previously approved these changes Dec 19, 2024
MartinSchoeler
MartinSchoeler previously approved these changes Dec 20, 2024
dougfabris
dougfabris previously approved these changes Dec 20, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Dec 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 20, 2024
@kodiakhq kodiakhq bot merged commit c9deda3 into develop Dec 20, 2024
47 checks passed
@kodiakhq kodiakhq bot deleted the fix/userAvatarEditor branch December 20, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants