Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: New room sound fired after reconnection #34202

Merged
merged 3 commits into from
Dec 18, 2024
Merged

fix: New room sound fired after reconnection #34202

merged 3 commits into from
Dec 18, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Dec 17, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Closes #33840

Steps to test or reproduce

Further comments

CORE-811

Copy link
Contributor

dionisio-bot bot commented Dec 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: c15ab3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 17, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34202/
on branch gh-pages at 2024-12-18 14:19 UTC

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.83%. Comparing base (037e692) to head (e66a7a8).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #34202      +/-   ##
===========================================
+ Coverage    75.81%   75.83%   +0.02%     
===========================================
  Files          512      511       -1     
  Lines        22205    22172      -33     
  Branches      5403     5397       -6     
===========================================
- Hits         16834    16814      -20     
+ Misses        4720     4710      -10     
+ Partials       651      648       -3     

@ggazzo ggazzo changed the title fix: wip fix: New room sound fired after reconnection Dec 17, 2024
@ggazzo ggazzo added this to the 7.2.0 milestone Dec 17, 2024
@ggazzo ggazzo marked this pull request as ready for review December 17, 2024 21:01
@ggazzo ggazzo requested a review from a team as a code owner December 17, 2024 21:01
dougfabris
dougfabris previously approved these changes Dec 17, 2024
dougfabris
dougfabris approved these changes Dec 18, 2024
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Dec 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 18, 2024
@kodiakhq kodiakhq bot merged commit 9521463 into develop Dec 18, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the fix/sound branch December 18, 2024 14:49
MartinSchoeler pushed a commit that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random phantom ding dong "door" notification sounds occurring
2 participants