-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: New room sound fired after reconnection #34202
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34202 +/- ##
===========================================
+ Coverage 75.81% 75.83% +0.02%
===========================================
Files 512 511 -1
Lines 22205 22172 -33
Branches 5403 5397 -6
===========================================
- Hits 16834 16814 -20
+ Misses 4720 4710 -10
+ Partials 651 648 -3 |
Co-authored-by: Douglas Fabris <[email protected]>
Proposed changes (including videos or screenshots)
Issue(s)
Closes #33840
Steps to test or reproduce
Further comments
CORE-811