Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decoder error preventing succesfull app subprocess restart #34880

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Jan 3, 2025

Backport of #34858

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner January 3, 2025 21:07
@dionisio-bot dionisio-bot bot requested a review from d-gubert January 3, 2025 21:07
Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: b77248e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages
Name Type
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/authorization-service Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/presence-service Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/account-service Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-theming Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/queue-worker Patch
@rocket.chat/apps-engine Patch
@rocket.chat/ui-composer Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/ui-client Patch
@rocket.chat/models Patch
@rocket.chat/sha256 Patch
@rocket.chat/meteor Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot bot added this to the 7.0 milestone Jan 3, 2025
Copy link
Contributor Author

dionisio-bot bot commented Jan 3, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot added backport and removed backport labels Jan 3, 2025
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jan 3, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34880/
on branch gh-pages at 2025-01-03 22:28 UTC

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.4@c51de29). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.4   #34880   +/-   ##
================================================
  Coverage                 ?   58.68%           
================================================
  Files                    ?     2789           
  Lines                    ?    66846           
  Branches                 ?    15026           
================================================
  Hits                     ?    39229           
  Misses                   ?    24795           
  Partials                 ?     2822           
Flag Coverage Δ
unit 74.96% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 63856f5 into release-7.0.4 Jan 3, 2025
9 of 10 checks passed
@kodiakhq kodiakhq bot deleted the backport-7.0.4-34858 branch January 3, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant