Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apps-engine reliability fixes #34906

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Jan 8, 2025

Backport of several fixes in the Apps-Engine.

Fixes published with Apps-Engine patch version 1.43.5 https://github.com/RocketChat/Rocket.Chat.Apps-engine/releases/tag/v1.43.5

The changes as listed on the Apps-Engine release:

Copy link
Contributor

dionisio-bot bot commented Jan 8, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.10.10, but it targets 6.10.9

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: afe493f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/omnichannel-services Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/authorization-service Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/presence-service Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/instance-status Patch
@rocket.chat/account-service Patch
@rocket.chat/message-parser Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/core-services Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/core-typings Patch
@rocket.chat/peggy-loader Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/queue-worker Patch
@rocket.chat/presence Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/license Patch
@rocket.chat/gazzodown Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/livechat Patch
@rocket.chat/models Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/meteor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.10.10@4ecb4c4). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release-6.10.10   #34906   +/-   ##
==================================================
  Coverage                   ?   56.60%           
==================================================
  Files                      ?     2504           
  Lines                      ?    55706           
  Branches                   ?    11529           
==================================================
  Hits                       ?    31533           
  Misses                     ?    21475           
  Partials                   ?     2698           
Flag Coverage Δ
e2e 56.47% <ø> (?)
unit 71.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review January 8, 2025 12:29
@d-gubert d-gubert requested review from a team as code owners January 8, 2025 12:29
@d-gubert d-gubert added this to the 6.10.10 milestone Jan 8, 2025
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jan 8, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 8, 2025
@kodiakhq kodiakhq bot merged commit 50837dd into release-6.10.10 Jan 8, 2025
50 checks passed
@kodiakhq kodiakhq bot deleted the fix/apps-engine-patch branch January 8, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants