Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open song/artist page by clicking on a song/artist title in the player. #410

Merged
merged 1 commit into from
Oct 23, 2015
Merged

Open song/artist page by clicking on a song/artist title in the player. #410

merged 1 commit into from
Oct 23, 2015

Conversation

mradionov
Copy link
Contributor

Allows to open song page by clicking on it's title or logo in the player and to open artist page by clicking on his name in the player. It is available on the SC website and I think is useful.

Basically I've added one more property to a track object, which is getting created by playerService - songUserId - using API data from tracks.html and playlists.html.

Also I've used ng-click approach because from my research data for player is added in real-time via DOM API from playerService (like appending track name and inserting logo), so just appending ui-sref the same way won't work. I wonder though if I should have added a method to playerService to get current track object instead of accessing queueService directly from a controller.

@weblancaster
Copy link
Member

@mradionov looks good this way.. thanks for working on it and sorry for my delay in review.

weblancaster added a commit that referenced this pull request Oct 23, 2015
Open song/artist page by clicking on a song/artist title in the player.
@weblancaster weblancaster merged commit 9d64680 into Soundnode:master Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants