Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fixes for errors in JS execution + artist names on follower pages #738

Merged
merged 1 commit into from
Apr 29, 2016

Conversation

dgattey
Copy link
Contributor

@dgattey dgattey commented Apr 13, 2016

Found a few small JS bugs related to data returned from the API that I fixed, plus an inconsistency in HTML I fixed.

  1. Searching may return less than 4 items, but the length of the collection was hardcoded, making the search results inaccessible if the search returned less than 4 items (search for "calvin har" in the current version to see this).
  2. If the user didn't have a description, followers wouldn't show up either because we assumed data.description would exist. Simple null check.
  3. Followers/following pages didn't have a link to the user if you clicked on the name of the user rather than the photo (despite the pointer cursor). So I added a link.

@dgattey
Copy link
Contributor Author

dgattey commented Apr 21, 2016

Anything to fix here? If not, what can I do to help merge it in?

@jakejarrett
Copy link
Member

I'll test this tonight

@jakejarrett
Copy link
Member

@dgattey Tested it finally (sorry for the delay) Everything looks good to me.

@jakejarrett jakejarrett merged commit c8ab194 into Soundnode:master Apr 29, 2016
@weblancaster
Copy link
Member

weblancaster commented Apr 29, 2016

Thanks @dgattey and thanks @jakejarrett for testing.

@dgattey dgattey deleted the bug-hotfixes branch May 2, 2016 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants