Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes scrubbing issues with mouse and window #750

Merged
merged 1 commit into from
Jul 1, 2016
Merged

Fixes scrubbing issues with mouse and window #750

merged 1 commit into from
Jul 1, 2016

Conversation

sillero
Copy link
Contributor

@sillero sillero commented Apr 23, 2016

fixes #516

  • 1px margin on the progress bar to detect when the mouse is leaving the window horizontally (effectively no visual impact)
  • dynamic vertical threshold to better manage the mouse behavior on scrubbing
  • needed to detect the gui.window focus/blur, so I'm dispatching it to jQuery too, which should also be useful in other scenarios

@weblancaster
Copy link
Member

Awesome work @sillero thanks a lot and sorry for my delay in reviewing.

@weblancaster weblancaster merged commit 98dce9d into Soundnode:master Jul 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Onmouse event for scrubbing doesnt end after leaving window
2 participants