Combine packet length prepending and compressor #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janmm14
force-pushed
the
combine-length-prepend-and-compress
branch
2 times, most recently
from
aecf5fd to
8fe7107
Compare
…mpressed length after compression (leaving some bytes free at start of buffer)
Janmm14
force-pushed
the
combine-length-prepend-and-compress
branch
from
8fe7107 to
b638dde
Compare
Janmm14
force-pushed
the
combine-length-prepend-and-compress
branch
from
01d8304 to
f12d512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we can prepend compressed length after compression (leaving some bytes free at start of buffer)
This way we make more use of the not eliminatable "copy" during compression.
This has been shortly tested with and without cipher present and works.
No performance benchmark has been done.
This has not been tested with native impl.Edit: works as well with native impl