-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support pk index major compaction in cloud native table #41737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TszKitLo40
force-pushed
the
pk-index-major-compaction
branch
6 times, most recently
from
February 28, 2024 13:24
58c73e7
to
e864f96
Compare
luohaha
reviewed
Feb 29, 2024
TszKitLo40
force-pushed
the
pk-index-major-compaction
branch
from
March 1, 2024 00:07
b2949a1
to
2f67798
Compare
luohaha
reviewed
Mar 27, 2024
luohaha
reviewed
Mar 27, 2024
TszKitLo40
force-pushed
the
pk-index-major-compaction
branch
from
March 29, 2024 07:28
f846161
to
c5d2c7b
Compare
TszKitLo40
force-pushed
the
pk-index-major-compaction
branch
4 times, most recently
from
March 29, 2024 12:15
52bd94e
to
0891f92
Compare
luohaha
reviewed
Apr 1, 2024
luohaha
reviewed
Apr 1, 2024
luohaha
reviewed
Apr 1, 2024
luohaha
reviewed
Apr 7, 2024
luohaha
previously approved these changes
Apr 7, 2024
luohaha
reviewed
Apr 7, 2024
luohaha
reviewed
Apr 7, 2024
Signed-off-by: Zijie Lu <[email protected]>
TszKitLo40
force-pushed
the
pk-index-major-compaction
branch
from
May 21, 2024 05:41
231bc48
to
6551a13
Compare
Signed-off-by: Zijie Lu <[email protected]>
luohaha
approved these changes
May 21, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 112 / 132 (84.85%) file detail
|
sevev
approved these changes
May 21, 2024
wyb
approved these changes
May 21, 2024
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 21, 2024
…1737) Signed-off-by: Zijie Lu <[email protected]> (cherry picked from commit a154a9a) # Conflicts: # be/src/storage/lake/lake_primary_index.cpp # be/src/storage/lake/lake_primary_index.h # be/src/storage/lake/update_manager.cpp # be/src/storage/lake/update_manager.h # be/src/storage/storage_engine.cpp
42 tasks
https://github.com/Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 21, 2024
…1737) Signed-off-by: Zijie Lu <[email protected]> (cherry picked from commit a154a9a)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
May 21, 2024
…ckport #41737) (#46002) Co-authored-by: Zijie Lu <[email protected]>
24 tasks
luohaha
pushed a commit
to luohaha/starrocks
that referenced
this pull request
Jun 17, 2024
…arRocks#41737) Signed-off-by: Zijie Lu <[email protected]>
This was referenced Jun 17, 2024
luohaha
added a commit
that referenced
this pull request
Jun 17, 2024
…ckport #41737) (#47112) Signed-off-by: Zijie Lu <[email protected]> Signed-off-by: luohaha <[email protected]> Co-authored-by: Zijie Lu <[email protected]>
42 tasks
luohaha
added a commit
that referenced
this pull request
Dec 18, 2024
…#41737) (#54067) Signed-off-by: luohaha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
PK index major compaction is not supported in cloud native table which will cause write amplification.
What I'm doing:
Support pk index major compaction in cloud native table.
WIthout pk index major compaction
With pk index major compaction
In trace log, we can see that the time of
primary_index_commit_latency_us
is much less that without major compaction. Because merge compaction is not needed in commit.Fix #45740
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: